Alter fallback for source-roots #9967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9967 +/- ##
==========================================
- Coverage 95.80% 95.80% -0.01%
==========================================
Files 174 174
Lines 18934 18939 +5
==========================================
+ Hits 18140 18144 +4
- Misses 794 795 +1
|
This comment has been minimized.
This comment has been minimized.
akamat10
force-pushed
the
disable_legacy_for_source_roots
branch
from
648b52c
to
2c0c0d6
Compare
This comment has been minimized.
This comment has been minimized.
|
As this is not primarily about |
Pierre-Sassoulas
added
Needs review 🔍
for more information, see https://pre-commit.ci
akamat10
force-pushed
the
disable_legacy_for_source_roots
branch
from
2bae088
to
6ef3156
Compare
This comment has been minimized.
This comment has been minimized.
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit fed3e42 |
This was referenced Sep 29, 2024
|
@akamat10 Can you tag me when this is ready for review? |
|
Will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Alter fallback for source-roots as discussed in #9955. This simplifies the import discovery logic, makes it easier to understand and supports the discovery process for more usecases (for example, src-layout or in cases where imported modules may be in a different directory from the files to be linted)
TODO:
Update changelog and documentation
Closes #9955